Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ERA5 fix to allow pressure-levels data with one pressure level #276

Merged
merged 2 commits into from
Nov 22, 2024

Conversation

jsmretschnig
Copy link

Behavior so far:

  • downloading ERA5 pressure-level data for a single pressure level caused an issue, as "level" was assigned to the dataset twice (due to the CDS-Beta compatibility bugfix)
  • downloading ERA5 pressure-level data works fine for multiple pressure levels
  • downloading ERA5 single-level data works fine

Now:

  • downloading ERA5 pressure-level data also works for a single pressure level

Tests

  • QC test locally (make test)
    -- 6 failed, 1017 passed, 161 skipped, 1 xpassed
    -- all the failed tests are GOES tests, and I manually skipped LEO tests
  • CI tests pass

Reviewer

Thanks @zebengberg !

@jsmretschnig jsmretschnig changed the title fix to allow pressure-levels data with one pressure level ERA5 fix to allow pressure-levels data with one pressure level Nov 21, 2024
Copy link
Contributor

@zebengberg zebengberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this! I made one suggestion that doesn't change the runtime behavior.

pycontrails/datalib/ecmwf/era5.py Outdated Show resolved Hide resolved
@zebengberg zebengberg merged commit 814f822 into contrailcirrus:main Nov 22, 2024
0 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants