Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/gfs #254

Merged
merged 9 commits into from
Oct 15, 2024
Merged

Fix/gfs #254

merged 9 commits into from
Oct 15, 2024

Conversation

zebengberg
Copy link
Contributor

@zebengberg zebengberg commented Oct 11, 2024

Closes #253

Features

  • Add cache_download parameter to the GFSForecast interface. When set to True, downloaded grib data is cached locally. This is consistent with the behavior of the ERA5ModelLevel and HRESModelLevel interfaces.

Fixes

  • Update GFS variable names "uswrf" -> "suswrf" and "ulwrf" -> "sulwrf". This accommodates a breaking change introduced in eccodes 2.38.

Tests

  • QC test passes locally (make test)
  • CI tests pass

Reviewer

Select @ reviewer

@zebengberg zebengberg requested a review from mlshapiro October 11, 2024 16:36
Copy link
Contributor

@mlshapiro mlshapiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need to change variable names.

Can you share how you were able to reproduce the error? I tried to to reproduce and did not see any issues.

pycontrails/datalib/gfs/variables.py Show resolved Hide resolved
Copy link
Contributor

@mlshapiro mlshapiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also require "eccodes>=2.38" in pyproject.toml so that when users re-install they will get this compatible version?

pycontrails/datalib/gfs/variables.py Show resolved Hide resolved
pycontrails/datalib/gfs/variables.py Show resolved Hide resolved
@zebengberg zebengberg merged commit 6a9b77a into main Oct 15, 2024
9 checks passed
@zebengberg zebengberg deleted the fix/gfs branch October 15, 2024 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GFSForecast radiation variables broken.
2 participants