-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/gfs #254
Fix/gfs #254
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we need to change variable names.
Can you share how you were able to reproduce the error? I tried to to reproduce and did not see any issues.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you also require "eccodes>=2.38"
in pyproject.toml so that when users re-install they will get this compatible version?
Co-authored-by: Marc Shapiro <[email protected]>
Co-authored-by: Marc Shapiro <[email protected]>
Closes #253
Features
cache_download
parameter to theGFSForecast
interface. When set toTrue
, downloaded grib data is cached locally. This is consistent with the behavior of theERA5ModelLevel
andHRESModelLevel
interfaces.Fixes
Tests
make test
)Reviewer