Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request to fix a typo in flowmod.go #33

Open
vanytsvetkov opened this issue Sep 9, 2024 · 0 comments
Open

Request to fix a typo in flowmod.go #33

vanytsvetkov opened this issue Sep 9, 2024 · 0 comments

Comments

@vanytsvetkov
Copy link

My apologies, however, are you sure that this code should look exactly like it does?

binary.BigEndian.PutUint32(bytes[n:], f.OutPort)
n += 4
binary.BigEndian.PutUint32(bytes[n:], f.OutPort)
n += 4

Perhaps you wanted to write something like:

        binary.BigEndian.PutUint32(bytes[n:], f.OutPort) 
        n += 4 
        binary.BigEndian.PutUint32(bytes[n:], f.OutGroup) 
        n += 4 

Just check the source code of OpenvSwitch to be completely sure.

        ofm->out_port = ofputil_port_to_ofp11(fm->out_port);
        ofm->out_group = htonl(fm->out_group);
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant