Build cleanup + release process #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Makefile
Outdated
| @@ -33,20 +33,22 @@ demo-swarm: | |||
| make cluster | |||
| make install-test-swarm | |||
|
|
|||
| # Create a release and test the release installation on a vagrant cluster | |||
| # Create a build and test the release installation on a vagrant cluster | |||
| # This should only be used with devbuild, else install-test-kubeadm will fail to | |||
There was a problem hiding this comment.
Isn't it expected to be used with non devbuilds for the case where we want to test the release before uploading it?
There was a problem hiding this comment.
I need to update the comment. Your PR already took care of that, right? Will double check.
There was a problem hiding this comment.
Yup, I see that scripts/kubeadm_test.sh already uses the local built one rather than download from github if present.
RELEASE.md
Outdated
| ``` | ||
|
|
||
| 2. Build docker binary image. This would create a docker image contiv/install:$BUILD_VERSION. | ||
|
|
There was a problem hiding this comment.
It also creates the release bundles release/contiv-.tgz and release/contiv-full-.tgz
neelimamukiri
approved these changes
Feb 21, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.