Add script to fetch netplugin release or build #275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding a script that can be used by the Makefile to either maintain existing behavior by default (download an existing release), or by adding environment variables, build netplugin based on a requested branch. Signed-off-by: Chris Plock <[email protected]>
dseevr
reviewed
Oct 19, 2017
| ${CONTIV_ARTIFACT_STAGING}/ | ||
| # create a link so other scripts can find the file without knowing the SHA | ||
| cd ${CONTIV_ARTIFACT_STAGING} | ||
| ln -sf netplugin-${GIT_COMMIT}.tar.bz2 $CONTIV_NETPLUGIN_TARBALL_NAME |
There was a problem hiding this comment.
Could we check that $CONTIV_NETPLUGIN_TARBALL_NAME is set at the top of the script instead of relying on -u to raise an error?
dseevr
approved these changes
Oct 19, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a script that can be used by the Makefile to either maintain
existing behavior by default (download an existing release), or by
adding environment variables, build netplugin based on a requested
branch.
Signed-off-by: Chris Plock [email protected]