fix: logger, custom attribute ref & error #1596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
aman19K
commented
Sep 27, 2024
•
aman19K
commented
- Custom attribute is not referenced in the target project’s audience
- Error handling in case of variant entry creation failed
- part of import logs going in to export folder
- API throwing error in case of Empty JSON RTE
- Marketplace undefined name in logs
- file field not importing if its made variant (DX-1516)
aman19K
requested review from
cs-raj,
shafeeqd959,
netrajpatel and
sunil-lakshman
and removed request for
cs-raj
cs-raj
approved these changes
Sep 30, 2024
cs-raj
pushed a commit
that referenced
this pull request
Oct 9, 2024
fix: logger, custom attribute ref & error
cs-raj
pushed a commit
that referenced
this pull request
Nov 11, 2024
fix: logger, custom attribute ref & error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.