feat(Rich Text Editor): add sticky offset property #1782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YvesRijckaert
approved these changes
Oct 17, 2024
cf-remylenoir
deleted the
CFISO-1962-markdown-rich-text-editors-overlap-with-the-sticky-entity-tabs
branch
|
@cf-remylenoir Nit, but to my eyes it feels like we're off by one pixel as we have both horizontal lines on top now 🤔 |
|
Yes, the offset value is set in the web app. I will bring it 1px less in my upcoming PR (the video reflects a WIP state) 🙂
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having the sticky entity editor tabs in the web app requires having a customizable offset for the Rich Text Editor sticky toolbar to ensure it stays visible when scrolling and not hidden behind the tabs.
Before
The toolbar is sticky behind the tabs.
before.mov
After
Adding the offset value matching the tabs' height ensures the toolbar stays visible.
after.mov