Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Client::getEntries() cache does not work properly with different locales #320

Closed
fabianaromagnoli opened this issue Jan 9, 2023 · 2 comments

Comments

@fabianaromagnoli
Copy link
Contributor

If you call Client::getEntries() method passing a Query that has no locale set, the cache key will not include the locale code, so that if you have entries in different locales, you will get the same cache content for any locale.
I think it is common to build a Query without setting a specific locale, because in this case the Client uses the default locale, and in most cases that's exactly what you want.

@fabianaromagnoli
Copy link
Contributor Author

I'm already working on a PR to fix this. Coming soon.

@fabianaromagnoli fabianaromagnoli changed the title getEntries cache does not work properly with different locales Client::getEntries() cache does not work properly with different locales Jan 9, 2023
@Sebb767
Copy link
Collaborator

Sebb767 commented Jan 26, 2023

Fixed with v7.0.1 - thanks!

@Sebb767 Sebb767 closed this as completed Jan 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants