Skip to content
This repository has been archived by the owner on Nov 3, 2023. It is now read-only.

Missing "tableless" class on registration module #7205

Closed
marcobiedermann opened this issue Jul 26, 2014 · 6 comments
Closed

Missing "tableless" class on registration module #7205

marcobiedermann opened this issue Jul 26, 2014 · 6 comments

Comments

@marcobiedermann
Copy link
Contributor

  • On registration form modules the "tableless" class is missing.
    For better consistency I recommend to add the class to the module
    contao-registration
@leofeyer leofeyer added this to the 3.2.13 milestone Jul 26, 2014
@marcobiedermann
Copy link
Contributor Author

"Tableless"-class is also missing on personal_data module
contao-personal-data

@fjacobi
Copy link

fjacobi commented Jul 26, 2014

Because there is no tableless class.
This has nothing to do with consistency. The table is an alternative to the default layout (being divs).
And why would one use an additional class for the default?

@marcobiedermann
Copy link
Contributor Author

@fjacobi there is a "tableless" class on other form elements. Either add it to all of them or remove it entirely

@fjacobi
Copy link

fjacobi commented Jul 27, 2014

@marcobiedermann Sorry, my mistake.
I created a pull request - both are based in the same template.

#7207

@marcobiedermann
Copy link
Contributor Author

@fjacobi No problem. Thank you very much for the pull request.

@leofeyer leofeyer removed this from the 3.4.0 milestone Sep 5, 2014
@leofeyer
Copy link
Member

leofeyer commented Sep 5, 2014

I'm closing the ticket in favor of #7207 then.

@leofeyer leofeyer closed this as completed Sep 5, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants