-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: docker service update with --detach=false
hangs on services wi…
#104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…th 0 tasks read more here: docker/cli#627
I fixed the pipeline issue. |
djmaze
reviewed
Jul 6, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Few comments.
djmaze
approved these changes
Jul 6, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM and seems to work. Thanks!
moschlar
added a commit
that referenced
this pull request
Oct 30, 2023
[Full Changelog](0.7.0...1.8.0) **Breaking changes:** - The docker image registry location has been changed to the containrrr organisation: `containrrr/shepherd` **Implemented enhancements:** - armhf support [\#108](#108) - Switch to official docker image v24 [\#107](#107) ([djmaze](https://github.com/djmaze)) - Restrict runtime of "docker service update" using "timeout" [\#98](#98) ([fooflington](https://github.com/fooflington)) - Add example for usage with swarm-cronjob [\#89](#89) ([djmaze](https://github.com/djmaze)) **Fixed bugs:** - Can't update some services: no such manifest [\#105](#105) - Service gets stuck when calling "docker service update" and won't progress [\#97](#97) - fix: docker service update with `--detach=false` hangs on services wi… [\#104](#104) ([AliRezaBeitari](https://github.com/AliRezaBeitari)) - Fix defunc VERBOSE handling [\#91](#91) ([sebthom](https://github.com/sebthom)) **Closed issues:** - How does it determine if there is an update or not? [\#111](#111) - Looking for a new maintainer [\#96](#96) - New OCI manifest issue [\#92](#92) - Run service update at a fixed time [\#88](#88) - docker swarm 20.10.12 | "docker service update" requires exactly 1 argument. [\#83](#83) - Error updating service, does not exist or it is not available when using a duplicate registry [\#78](#78) **Merged pull requests:** - Add apprise type and additional error notification [\#118](#118) ([andyloree](https://github.com/andyloree)) - Rename image in docs [\#114](#114) ([moschlar](https://github.com/moschlar)) - Fix release workflow [\#113](#113) ([moschlar](https://github.com/moschlar)) - Update README.md [\#103](#103) ([andrew-dixon](https://github.com/andrew-dixon)) - ci: add basic github actions for build/release [\#101](#101) ([piksel](https://github.com/piksel)) - correct misleading description of WITH\_NO\_RESOLVE\_IMAGE [\#100](#100) ([alex-vg](https://github.com/alex-vg)) - Move example configs to their own folder [\#99](#99) ([djmaze](https://github.com/djmaze)) - Add documentation about `REGISTRIES_FILE` [\#94](#94) ([tito](https://github.com/tito)) - Minor refactoring [\#90](#90) ([sebthom](https://github.com/sebthom)) Closes: #117
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a service has 0 tasks, the
docker service update
command with the--detach=false
parameter hangs.Read more here: docker/cli#627