Add ability to set authenticated user in request header #889
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some web applications provide the ability to authorize users based on the authenticated from Basic Auth. This patch provides a way to set a key to which the authenticated user can be set in the Header. For example, if I set `HeaderValue = "X-WebAuth-User"` and authenticate, my application will be able to read my user name from that header and provide me with the proper access. This fixes traefik#802
|
Let me know if there is additional documentation or tests you'd like to see. Also, I'm happy to squash commit and re-open to clean out the documentation commit and misspelling. |
vdemeester
approved these changes
Dec 8, 2016
|
Hmm. I think I have a typo in the documentation. I'll push an update today.
…On Thu, Dec 8, 2016, 2:25 AM Vincent Demeester ***@***.***> wrote:
***@***.**** approved this pull request.
LGTM 🐮
/cc @containous/traefik <https://github.com/orgs/containous/teams/traefik>
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#889 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAIXQXynWp8F59M27sCD3vO_IMHDsGT9ks5rF9skgaJpZM4K7J3Y>
.
|
emilevauge
approved these changes
Dec 16, 2016
There was a problem hiding this comment.
LGTM, thanks @ViViDboarder
Please squash commits while merging
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some web applications provide the ability to authorize users based on
the authenticated from Basic Auth. This patch provides a way to set a
key to which the authenticated user can be set in the Header.
For example, if I set
HeaderValue = "X-WebAuth-User"and authenticate,my application will be able to read my user name from that header and
provide me with the proper access.
This fixes #802