consul/kv.tmpl: weight default value should be a int #826
Conversation
|
Forgot to update some tests.. kv_test.go, kubernetes_test.go and docker_test.go I think.. |
|
Hey @klausenbusk, thanks a lot for your contribution :-) Before we can move any further, a rebase is needed. Thanks a lot! |
|
Rebase done. |
|
And another one please :( @klausenbusk |
|
Hmm, I clicked the update branch button, which merged the last "v1.1". |
|
Please rebase your branch "properly" so that's it's only 1 commit (without the merge stuff ;)). It would just blow our history :) Thanks @klausenbusk |
|
Why can't Github do that :) |
|
Done I also changed the kv_test.go to use weight 0. Not that it matters. |
|
Ping @containous/traefik |
|
Needs a rebase to be just one Commit I guess? Besides LGTM |
| @@ -261,7 +261,7 @@ func (provider *Kubernetes) loadIngresses(k8sClient k8s.Client) (*types.Configur | |||
| log.Warnf("Endpoints not found for %s/%s, falling back to Service ClusterIP", service.ObjectMeta.Namespace, service.ObjectMeta.Name) | |||
| templateObjects.Backends[r.Host+pa.Path].Servers[string(service.UID)] = types.Server{ | |||
| URL: protocol + "://" + service.Spec.ClusterIP + ":" + strconv.Itoa(port.Port), | |||
| Weight: 1, | |||
| Weight: 0, | |||
There was a problem hiding this comment.
Not sure about this change... I don't think we need this since k8s does not add servers to the backend until they are ready...
* consul/kv.tmpl: weight default value should be a int Fix #821 * Use 0 as default weight in all backends
Fix #821
Use 0 as default weight in all backends
Note: Not tested..