Name servers after their pods #596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ping @containous/traefik |
|
LGTM :) |
emilevauge
added
contributor/needs-resolve-conflicts
status/3-needs-merge
and removed
status/2-needs-review
labels
|
LGTM 🐱 but I feel this whole method needs some refactoring to be more readable |
|
@vdemeester I agree. I have some plans to do some fairly extensive refactoring of this provider, as in its current form stuff is quite hard to test, and to grock, so I would rather keep this change smaller, and clean stuff up later. |
The TargetRef contains information from the object referenced by the pod, unless the service has been set up with bare endpoints - i.e. not pointing at pods this information will be present. It just makes the information that we show in the web-ui a little more constent with that shown in kubectl and the kuberntes dashboard.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The TargetRef contains information from the object referenced
by the pod, unless the service has been set up with bare
endpoints - i.e. not pointing at pods this information
will be present.
It just makes the information that we show in the web-ui
a little more constent with that shown in kubectl
and the kuberntes dashboard.