Add command storeconfig #551
Conversation
cocap10
force-pushed
the
upload-config-kv
branch
5 times, most recently
from
e882005
to
eacd025
Compare
| To do that, we can send the Key-value pairs via [curl commands](https://www.consul.io/intro/getting-started/kv.html) or via the [Web UI](https://www.consul.io/intro/getting-started/ui.html). | ||
|
|
||
| Hopefully, we had automated this process with the `storeconfig` Træfɪk command. | ||
| Please refer to the [store Træfɪk configuration](/user-guide/kv-config/#store-configuration-in-key-value-store) section to get documentation on it. | ||
|
|
||
| Here the toml configuration we would like to store in the Key-value Store : |
|
You should specify that "In case you are setting key values manually", because you were talking about using |
| # Store configuration in Key-value store | ||
|
|
||
| The static Træfɪk configuration can be automatically uploaded form Træfɪk into a Key-value Store. |
There was a problem hiding this comment.
uration can be automatically -> soooo much spaces ^^
|
Well done @cocap10 🎉 /cc @containous/traefik |
|
Thank you @emilevauge |
cocap10
force-pushed
the
upload-config-kv
branch
from
1581c08
to
3a7a2b5
Compare
|
And rebased ;) |
|
|
||
| Here the toml configuration we would like to store in the Key-value Store : | ||
| Hopefully, we had automated this process with the `storeconfig` Træfɪk command. |
There was a problem hiding this comment.
hum not sure about the past here.
Hopefully, Træfɪk allows automation of this process using the `storeconfig` subcommand.
|
I guess it's for 1.1, so I added the milestone. @cocap10 few nits/comments but overall looks pretty good ! |
| os.Exit(-1) | ||
| } | ||
| // IF a KV Store is enable and no sub-command called in agrs | ||
| if kv != nil && usedCmd == traefikCmd { | ||
| s.AddSource(kv) | ||
| if _, err := s.LoadConfig(); err != nil { | ||
| fmtlog.Println(err) |
There was a problem hiding this comment.
You'r right ;)
And same there https://github.com/containous/traefik/pull/551/files#diff-dba3f2b16983e1351d5b02a5700d18ecR134 I think !
cocap10
force-pushed
the
upload-config-kv
branch
2 times, most recently
from
5ed8ed4
to
a0ac6d6
Compare
add test integration command storeconfig update doc
cocap10
force-pushed
the
upload-config-kv
branch
from
a0ac6d6
to
1bb3d9b
Compare
|
LGTM |
|
LGTM 🐸 |
|
LGTM |
ldez
added
status/3-needs-merge
and removed
status/2-needs-review
status/1-needs-design-review
labels
This PR adds the command
storeconfigwhich stores the static traefik configuration into a Key-value stores.TODO :