Fix mistake in the documentation of several backends #4133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR changes the documentation for the following three labels to say that they add a HPKP header instead of a pinned HTST public key header.
<prefix>.frontend.headers.publicKey=VALUE(Consul Catalog)traefik.frontend.headers.publicKey=VALUE(Azure Service Fabric, Docker, ECS, Marathon, Mesos, Rancher)ingress.kubernetes.io/public-key: VALUE(Kubernetes Ingress)Motivation
The documentation for these labels currently says that they add a pinned HTST public key header. The problem with this is that there is no such thing as a pinned HTST (?) or even HSTS (HTTP Strict Transport Security) public key header. What these labels actually do is add a HPKP (HTTP Public Key Pinning) header.
More
Additional Notes
N/A