Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DNS challenge Cloudflare auth zone #4042

Merged
merged 3 commits into from
Oct 15, 2018
Merged

DNS challenge Cloudflare auth zone #4042

merged 3 commits into from
Oct 15, 2018

Conversation

ldez
Copy link
Contributor

@ldez ldez commented Oct 14, 2018

What does this PR do?

Fix: DNS challenge Cloudflare auth zone

Extra: add DreamHost

Motivation

Fixes some bugs.

More

  • [-] Added/updated tests
  • [-] Added/updated documentation

@ldez ldez added status/2-needs-review area/acme kind/bug/fix a bug fix bot/light-review decreases the number of required LGTM from 3 to 1. labels Oct 14, 2018
@traefiker traefiker added this to the 1.7 milestone Oct 14, 2018
mmatur
mmatur approved these changes Oct 15, 2018
View reviewed changes
Copy link
Member

@mmatur mmatur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker merged commit 7c2409b into traefik:v1.7 Oct 15, 2018
@traefiker traefiker removed bot/light-review decreases the number of required LGTM from 3 to 1. status/3-needs-merge labels Oct 15, 2018
@ldez ldez deleted the fix/acme-cloudflare branch October 15, 2018 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmatur mmatur mmatur approved these changes

Assignees
No one assigned
Labels
area/acme kind/bug/fix a bug fix size/S
Projects
None yet
Milestone
1.7
Development

Successfully merging this pull request may close these issues.
3 participants
@ldez @mmatur @traefiker