Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ACME DNS challenges #3998

Merged
merged 3 commits into from
Oct 10, 2018
Merged

ACME DNS challenges #3998

merged 3 commits into from
Oct 10, 2018

Conversation

ldez
Copy link
Contributor

@ldez ldez commented Oct 9, 2018 •
edited
Loading

What does this PR do?

Fix DNS Challenges for:

  • Gandi v5
  • NS1
  • DNSimple
  • Route53
  • Namecheap

Extra:

  • Add DNS provider for Linode APIv4
  • Add support for reading DNS provider setup from files
  • cloudflare: support for CF_API_KEY and CF_API_EMAIL

Motivation

Fixes #3989, #3977, #3957

@traefiker traefiker added this to the 1.7 milestone Oct 9, 2018
@ldez ldez changed the title Fix/acme challenges acme challenges Oct 9, 2018
@ldez ldez changed the title acme challenges ACME DNS challenges Oct 9, 2018
juliens
juliens approved these changes Oct 10, 2018
View reviewed changes
Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mmatur
mmatur approved these changes Oct 10, 2018
View reviewed changes
Copy link
Member

@mmatur mmatur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

nmengin
nmengin approved these changes Oct 10, 2018
View reviewed changes
Copy link
Contributor

@nmengin nmengin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@traefiker traefiker merged commit 5bdf8a5 into traefik:v1.7 Oct 10, 2018
This was referenced Oct 10, 2018
Closed
Closed
Closed
@ldez ldez deleted the fix/acme-challenges branch October 10, 2018 14:28
@Dunky13
Copy link

Dunky13 commented Oct 11, 2018

For me there is confusion about the Cloudflare Env variables.
Is is CLOUDFLARE_EMAIL or CF_API_EMAIL
This change is only documented for 1.7 but not for 1.6 or master.

@ldez
Copy link
Contributor Author

ldez commented Oct 11, 2018 •
edited
Loading

In 1.7 (>1.7.2) you can use both 😃 (CLOUDFLARE_XXX, CF_XXX)

in 1.6 only CLOUDFLARE_XXX

@Dunky13
Copy link

Dunky13 commented Oct 11, 2018

Could this be documented please? And if CLOUDFLARE_XXX is going to be deprecated (I don't know if it is or isn't) would be nice to know. This is currently kind of confusing.

@ldez
Copy link
Contributor Author

ldez commented Oct 11, 2018

The both are supported (no deprecation) but we recommend to use CF_XXX because it's a more standard for Cloudflare.

@ldez ldez mentioned this pull request Oct 23, 2018
Closed
leifcr added a commit to leifcr/charts that referenced this pull request Jun 13, 2019
@leifcr
Update cloudflare env variable names to match new format
739ebd3 
After 1.17, CF_API_x is preferred. See https://docs.traefik.io/configuration/acme/#dnschallenge and traefik/traefik#3998
@leifcr leifcr mentioned this pull request Jun 13, 2019
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nmengin nmengin nmengin approved these changes

@mmatur mmatur mmatur approved these changes

@juliens juliens juliens approved these changes

Assignees
No one assigned
Labels
area/acme kind/bug/fix a bug fix size/S
Projects
None yet
Milestone
1.7
Development

Successfully merging this pull request may close these issues.
6 participants
@ldez @Dunky13 @juliens @mmatur @nmengin @traefiker