Case insensitive host rule #3931
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It's normal that tests are failing because the fix is in containous/mux#5. |
jbdoumenjou
added
status/1-needs-design-review
area/rules
and removed
status/0-needs-triage
labels
mmatur
added
status/2-needs-review
bot/no-merge
and removed
status/1-needs-design-review
labels
|
Thanks you for your PR. I made a PR on containous/mux#6. Do you think you can add a test to verify that the rule Moreover, this a bug fix so I think we can merge it in the next 1.7. Can you make this PR on the 1.7 branch? |
ldez
changed the title
ldez
force-pushed
the
improve-hostRegexp-func
branch
from
254558d
to
3d5ec96
Compare
ldez
force-pushed
the
improve-hostRegexp-func
branch
2 times, most recently
from
437ce38
to
f735001
Compare
…dled (host patterns instead of plain hostnames)
traefiker
force-pushed
the
improve-hostRegexp-func
branch
from
f735001
to
dd528e5
Compare
|
Thank you guys for merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR introduces a failing test for issue #3930.
Here we also rename parameters and variables in the
hostRegexp()function to better reflect what is actually handled. Indeed, this function is written as if it was manipulating plain hostnames, whereas it actually handles host patterns that might include regular expressions.Motivation
I wanted to demonstrate the issue #3930, and also address a misnaming that was pointed out while analyzing that issue.
More
Additional Notes
Relates to #3930.