Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable retry on websocket #3825

Merged
merged 2 commits into from
Aug 29, 2018
Merged

Enable retry on websocket #3825

merged 2 commits into from
Aug 29, 2018

Conversation

juliens
Copy link
Member

@juliens juliens commented Aug 27, 2018 •
edited by ldez
Loading

What does this PR do?

Enable retry on websocket

Motivation

Having retry on websocket

Related to #3285

More

  • Added/updated tests

@traefiker traefiker added this to the 1.7 milestone Aug 27, 2018
@juliens juliens force-pushed the websocket-retry branch 2 times, most recently from c5e9b65 to 2bf89d8 Compare August 28, 2018 12:56
@jbdoumenjou
Copy link
Member

LGTM

nmengin
nmengin approved these changes Aug 29, 2018
View reviewed changes
Copy link
Contributor

@nmengin nmengin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👏 👏

ldez
ldez approved these changes Aug 29, 2018
View reviewed changes
Copy link
Contributor

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mmatur
mmatur approved these changes Aug 29, 2018
View reviewed changes
Copy link
Member

@mmatur mmatur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

juliens and others added 2 commits August 29, 2018 09:40
@traefiker traefiker merged commit f400292 into traefik:v1.7 Aug 29, 2018
@ldez ldez added the kind/bug/fix a bug fix label Aug 30, 2018
@juliens juliens deleted the websocket-retry branch September 6, 2019 05:38
This was referenced Sep 6, 2021
Open
Open
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nmengin nmengin nmengin approved these changes

@ldez ldez ldez approved these changes

@mmatur mmatur mmatur approved these changes

Assignees
No one assigned
Labels
area/middleware area/websocket kind/bug/fix a bug fix size/S
Projects
None yet
Milestone
1.7
Development

Successfully merging this pull request may close these issues.
6 participants
@juliens @jbdoumenjou @mmatur @ldez @nmengin @traefiker