Fix documentation for route53 acme provider #3811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dduportal
added
area/provider/ecs
area/documentation
status/1-needs-design-review
and removed
area/provider/ecs
status/0-needs-triage
labels
mmatur
added
status/2-needs-review
bot/no-merge
and removed
status/1-needs-design-review
labels
mmatur
changed the title
"If AWS_HOSTED_ZONE_ID is not set, Lego tries to determine the correct public hosted zone via the FQDN." - https://github.com/xenolf/lego/blob/master/providers/dns/route53/route53.go. The field is optional and it needs to be highlighted, otherwise, people might assume that traefik/lego can only support one Hosted Zone. I believe AWS_REGION should be optional as well. Even though it's used everywhere in lego examples, as far as I'm aware all domains in route53 are global and don't belong to a particular region. I've tested DNS challenge a few times without specifying AWS_REGION and everything works as expected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"If
AWS_HOSTED_ZONE_IDis not set, Lego tries to determine the correct public hosted zone via the FQDN." - https://github.com/xenolf/lego/blob/master/providers/dns/route53/route53.go.The field is optional and it needs to be highlighted, otherwise, people might assume that
traefik/legocan only support oneHosted Zone.I believe
AWS_REGIONshould be optional as well. Even though it's used everywhere inlegoexamples, as far as I'm aware all domains inroute53are global and don't belong to a particular region. I've tested DNS challenge a few times without specifyingAWS_REGIONand everything works as expected.