Handle shutdown of Hijacked connections #3636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldez
added
status/2-needs-review
contributor/waiting-for-corrections
and removed
status/0-needs-triage
labels
juliens
force-pushed
the
websocket-timeout
branch
2 times, most recently
from
3338cde
to
83027ef
Compare
juliens
force-pushed
the
websocket-timeout
branch
from
83027ef
to
a7d9e2b
Compare
mmatur
requested changes
Jul 19, 2018
server/server.go
Outdated
| @@ -140,7 +222,7 @@ func NewServer(globalConfiguration configuration.GlobalConfiguration, provider p | |||
| return server | |||
| } | |||
|
|
|||
| // Start starts the server. | |||
| //Start starts the server. | |||
There was a problem hiding this comment.
Could you please add a space after //
server/server.go
Outdated
| if state == http.StateHijacked { | ||
| serverEntryPoint.hijackConnectionTracker.AddHijackedConnection(conn) | ||
| } | ||
| if state == http.StateClosed { |
There was a problem hiding this comment.
Or maybe a switch case. Like you prefer
mmatur
force-pushed
the
websocket-timeout
branch
from
a7d9e2b
to
554a25f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Handle the shutdown of Hijacked connections (like websocket connection for example)
Motivation
Fixes #3630