Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix path to the debug pprof API #3608

Merged
merged 1 commit into from
Jul 12, 2018
Merged

Fix path to the debug pprof API #3608

merged 1 commit into from
Jul 12, 2018

Conversation

multani
Copy link
Contributor

@multani multani commented Jul 12, 2018

What does this PR do?

This improves the documentation to reach the debugging pprof API.

Motivation

I'm trying to debug what I suspect is a memory leak in Traefik and I saw that setting the debug flag enables pprof information "on /debug/pprof", but reaching this URL returned a 404.

I had to look at the source code to see how the handlers were configured to realize the trailing / was mandatory.

More

  • Added/updated tests
  • Added/updated documentation

Additional Notes

I wonder if the various /debug/... endpoint should be documented in this table as well. If you think it's OK to add the /debug/vars and the 4 or 5 /debug/pprof/... endpoint there, I can update this PR to put them there at the same time.

@mmatur mmatur changed the base branch from master to v1.6 July 12, 2018 15:43
@mmatur mmatur added this to the 1.6 milestone Jul 12, 2018
Copy link
Member

@mmatur mmatur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker merged commit f0ab272 into traefik:v1.6 Jul 12, 2018
@multani multani deleted the pprof-doc branch July 17, 2020 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants