Add xforwarded method #3424
Merged
Add xforwarded method #3424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldez
added
status/1-needs-design-review
status/2-needs-review
and removed
status/0-needs-triage
status/1-needs-design-review
labels
erik-sjoestedt
force-pushed
the
add_xforwarded_method
branch
from
b0f2db9
to
80376f7
Compare
nmengin
approved these changes
Jun 13, 2018
traefiker
force-pushed
the
add_xforwarded_method
branch
from
80376f7
to
c1dfbd2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Added requested Method to auth server for Forward Authentication.
Motivation
Missing feature for authentication decision based on the request method. For example CORS responses can not be forwarded to API-endpoints without the ability to white list OPTIONS in the auth server. This could also be solved by #2162 but this ticket still holds merit.
More
Added implementation and test.
Additional Notes
The PR is very close cousin of #2398
There is no standard header for forwarding the HTTP Verb so I went with
X-Forwarded-Method