Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helm installation using values #3392

Merged
merged 1 commit into from
May 30, 2018
Merged

Helm installation using values #3392

merged 1 commit into from
May 30, 2018

Conversation

erikaulin
Copy link
Contributor

@erikaulin erikaulin commented May 25, 2018

What does this PR do?

Added some basic information on how a user can extend the helm installation using a values.yaml.

Motivation

Hope to extend more documentation on how to use helm installation.

More

  • Added/updated tests
  • Added/updated documentation

Additional Notes

I wrote a blog post on how it can be extended to work let's encrypt and DNS-01 challenge.
LINK
Would like to extend the official helm documentation at one point.

Copy link
Contributor

@dtomcej dtomcej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
:shipit:

@ldez ldez changed the base branch from master to v1.6 May 30, 2018 01:36
@ldez ldez removed the bot/no-merge label May 30, 2018
Copy link
Member

@mmatur mmatur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Added some basic information on how a user can extend the helm installation using a values.yaml.
I wrote a blog post on how it can be extended to work let's encrypt and DNS-01 challenge. 
https://medium.com/@aulin/letsencrypt-tls-certificates-on-aks-azure-kubernetes-service-cluster-using-traefik-with-e9bcc7a9355a
@traefiker traefiker merged commit 36e2737 into traefik:v1.6 May 30, 2018
@mmatur mmatur changed the title helm installation using values Helm installation using values Jun 5, 2018
@erikaulin erikaulin deleted the patch-1 branch July 14, 2018 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants