-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Segments Labels: Mesos #3383
Merged
Merged
Segments Labels: Mesos #3383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldez
added
kind/enhancement
a new or improved feature.
status/2-needs-review
and removed
status/0-needs-triage
labels
May 24, 2018
ldez
approved these changes
May 28, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
dtomcej
approved these changes
May 28, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
juliens
approved these changes
Jun 5, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
traefik.portName
labelprovider/mesos/config_test.go
for both of the abovedocs/configuration/backends/mesos.md
Motivation
Segment labels were missing from the mesos provider and they are obviously very useful and sometimes required for mesos frameworks running many multi-port tasks.
Related to #3383
More
Additional Notes
Regarding the design: My primary goal was to keep these changes backwards compatible with the existing templates, so I kept the
taskData
object basically the same except for the addition of theSegmentName
. This approach means that when there are segments, thestate.Task
is duplicated per segment, but it also means that the majority of the code and templates usingtaskData.TraefikLabels
and the embeddedstate.Task
can remain the same.