-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix segment backend name #3317
Merged
Merged
Fix segment backend name #3317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldez
added
status/2-needs-review
area/provider/docker
area/provider/rancher
kind/bug/fix
a bug fix
labels
May 12, 2018
ldez
force-pushed
the
fix/docker-segment-backend-name
branch
from
May 13, 2018 17:04
8be2928
to
35cb935
Compare
mmatur
approved these changes
May 14, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
nmengin
approved these changes
May 14, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
juliens
approved these changes
May 14, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
traefiker
approved these changes
May 14, 2018
traefiker
force-pushed
the
fix/docker-segment-backend-name
branch
from
May 14, 2018 08:02
35cb935
to
6ac101c
Compare
This was referenced May 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix segment backend name.
Before this PR:
The label
traefik.backend
was partially ignored.The
traefik.<segment_name>.frontend.backend
label was used to name segment backend, this suggested that it was possible to set a backend manually for a frontend but it's not.With this PR:
The label
traefik.backend
is fully used.The
traefik.<segment_name>.frontend.backend
label is removed for the benefit oftraefik.<segment_name>.backend
Motivation
Fix a bug.
More