Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add basicAuth example for KV #3274

Merged
merged 2 commits into from
May 18, 2018
Merged

Add basicAuth example for KV #3274

merged 2 commits into from
May 18, 2018

Conversation

MichaelErmer
Copy link
Contributor

@MichaelErmer MichaelErmer commented May 6, 2018 •
edited by ldez
Loading

What does this PR do?

added basicAuth to the example

  • Added/updated documentation

@emilevauge
Copy link
Member

Hey @MichaelErmer, thank you for your contribution !
We think that our user guide should stay as simple as possible and thus, it appears that basic authentication may not appear in that section. I will close this PR then. Thanks again :)

@emilevauge emilevauge closed this May 7, 2018
@MichaelErmer
Copy link
Contributor Author

@emilevauge But its the only place where the K/V Storage is documented at all, all other pages are linking to that page, eg.: Please refer to the Key Value storage structure section to get documentation on Traefik KV structure.https://docs.traefik.io/configuration/backends/consul/

@emilevauge emilevauge reopened this May 7, 2018
@emilevauge
Copy link
Member

emilevauge commented May 7, 2018 •
edited
Loading

Indeed @MichaelErmer, you are right. Sorry for being a bit too fast on this one...

@mmatur mmatur added this to the 1.6 milestone May 7, 2018
@mmatur mmatur changed the base branch from master to v1.6 May 7, 2018 13:27
@ldez ldez self-assigned this May 16, 2018
ldez
ldez approved these changes May 16, 2018
View reviewed changes
Copy link
Contributor

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ldez ldez removed the bot/no-merge label May 16, 2018
@ldez ldez changed the title Update kv-config.md Add basicAuth example for KV May 16, 2018
dtomcej
dtomcej approved these changes May 16, 2018
View reviewed changes
Copy link
Contributor

@dtomcej dtomcej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
:shipit:

juliens
juliens approved these changes May 18, 2018
View reviewed changes
Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

MichaelErmer and others added 2 commits May 18, 2018 15:36
@traefiker traefiker merged commit 5501842 into traefik:v1.6 May 18, 2018
@MichaelErmer MichaelErmer deleted the patch-1 branch March 20, 2019 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtomcej dtomcej dtomcej approved these changes

@ldez ldez ldez approved these changes

@juliens juliens juliens approved these changes

Assignees

@ldez ldez

Labels
area/documentation area/provider/kv kind/enhancement a new or improved feature. size/S
Projects
None yet
Milestone
1.6
Development

Successfully merging this pull request may close these issues.
7 participants
@MichaelErmer @emilevauge @juliens @ldez @dtomcej @mmatur @traefiker