Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore server for container with empty IP address. #3213

Merged
merged 2 commits into from
Apr 22, 2018
Merged

Ignore server for container with empty IP address. #3213

merged 2 commits into from
Apr 22, 2018

Conversation

ldez
Copy link
Contributor

@ldez ldez commented Apr 19, 2018 •
edited
Loading

What does this PR do?

Ignore server for container with empty IP address.

Motivation

Fix a bug

More

  • Added/updated tests

@ldez ldez requested a review from a team as a code owner April 19, 2018 20:17
@traefiker traefiker added this to the 1.6 milestone Apr 19, 2018
@ldez ldez requested a review from a team as a code owner April 19, 2018 20:23
@ldez ldez changed the title fix: container without valid ip address. fix: container with empty ip address. Apr 19, 2018
@ldez ldez changed the title fix: container with empty ip address. Ignore server for container with empty IP address. Apr 19, 2018
SantoDE
SantoDE approved these changes Apr 19, 2018
View reviewed changes
Copy link
Collaborator

@SantoDE SantoDE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👼 Thanks 🙏🏻 @ldez

nmengin
nmengin approved these changes Apr 20, 2018
View reviewed changes
Copy link
Contributor

@nmengin nmengin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

juliens
juliens approved these changes Apr 22, 2018
View reviewed changes
Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker merged commit 7ef8d6f into traefik:v1.6 Apr 22, 2018
@ldez ldez deleted the fix/docker-no-ipaddress branch April 22, 2018 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nmengin nmengin nmengin approved these changes

@SantoDE SantoDE SantoDE approved these changes

@juliens juliens juliens approved these changes

Assignees
No one assigned
Labels
area/provider/docker area/provider/rancher kind/bug/fix a bug fix size/M
Projects
None yet
Milestone
1.6
Development

Successfully merging this pull request may close these issues.
5 participants
@ldez @juliens @SantoDE @nmengin @traefiker