Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update kubernetes.md #3171

Merged
merged 1 commit into from
Apr 11, 2018
Merged

Update kubernetes.md #3171

merged 1 commit into from
Apr 11, 2018

Conversation

andreyfedoseev
Copy link

What does this PR do?

The password created by htpasswd is encoded with MD5, not Base64

Motivation

More

  • Added/updated tests
  • Added/updated documentation

Additional Notes

@andreyfedoseev andreyfedoseev requested a review from a team as a code owner April 10, 2018 23:16
timoreimann
timoreimann approved these changes Apr 10, 2018
View reviewed changes
Copy link
Contributor

@timoreimann timoreimann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ldez ldez added this to the 1.6 milestone Apr 10, 2018
juliens
juliens approved these changes Apr 11, 2018
View reviewed changes
Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andreyfedoseev andreyfedoseev requested review from a team as code owners April 11, 2018 08:06
@mmatur mmatur changed the base branch from master to v1.6 April 11, 2018 08:06
@traefiker traefiker merged commit 21f6f81 into traefik:v1.6 Apr 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nmengin nmengin nmengin approved these changes

@timoreimann timoreimann timoreimann approved these changes

@juliens juliens juliens approved these changes

Assignees
No one assigned
Labels
area/documentation area/provider/k8s/ingress size/S
Projects
None yet
Milestone
1.6
Development

Successfully merging this pull request may close these issues.
7 participants
@andreyfedoseev @juliens @timoreimann @nmengin @mmatur @ldez @traefiker