Factorize labels managements. #3099
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldez
added
kind/enhancement
ldez
force-pushed
the
feature/labels-factorized
branch
from
dead79e
to
6eb53db
Compare
ldez
force-pushed
the
feature/labels-factorized
branch
6 times, most recently
from
8d31825
to
20f1bfc
Compare
mmatur
requested changes
Mar 30, 2018
| ) | ||
|
|
||
| func TestBuildConfigurationV1(t *testing.T) { | ||
| tests := []struct { |
There was a problem hiding this comment.
Could you please rename tests into testCases
| } | ||
|
|
||
| func TestGetFuncStringValueV1(t *testing.T) { | ||
| tests := []struct { |
There was a problem hiding this comment.
Could you please rename tests into testCases
| } | ||
|
|
||
| func TestGetFuncSliceStringV1(t *testing.T) { | ||
| tests := []struct { |
There was a problem hiding this comment.
Could you please rename tests into testCases
| } | ||
| } | ||
|
|
||
| func TestGetFuncSliceStringV1(t *testing.T) { |
There was a problem hiding this comment.
Could you please rename TestGetFuncSliceStringV1 into TestGetFuncSliceString
There was a problem hiding this comment.
I renamed GetFuncSliceString to GetFuncSliceStringV1 instead.
provider/consulcatalog/config.go
Outdated
| "getTag": getTag, | ||
| "hasTag": hasTag, | ||
| } | ||
| tmpl := template.New("consul catalog frontend rule").Funcs(FuncMap) |
There was a problem hiding this comment.
You could replace this next two lines with only one line
p.frontEndRuleTemplate = template.New("consul catalog frontend rule").Funcs(FuncMap)
provider/consulcatalog/config.go
Outdated
| // If the returned result is a singular marker, return the 'key' component | ||
| return kv[0] | ||
| } | ||
|
|
There was a problem hiding this comment.
Could you please remove this line
| test := test | ||
| t.Run(test.desc, func(t *testing.T) { | ||
|
|
||
| actualConfig := p.buildConfigurationV1(test.tasks) |
There was a problem hiding this comment.
Is there a reason do don't run these test cases in parallel ?
ldez
force-pushed
the
feature/labels-factorized
branch
from
888c818
to
c083479
Compare
ldez
force-pushed
the
feature/labels-factorized
branch
from
7a3a1c4
to
c2d7b22
Compare
ldez
force-pushed
the
feature/labels-factorized
branch
from
c2d7b22
to
03a295e
Compare
traefiker
force-pushed
the
feature/labels-factorized
branch
from
03a295e
to
86d57a4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Factorize labels managements for:
Motivation
Homogenization of the providers [part5]: have a shared way to manage labels.
More
Additional Notes
Related to #2785