Allow overriding the log level in debug mode. #3050
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timoreimann
added
kind/enhancement
timoreimann
force-pushed
the
allow-log-level-override-on-debug-switch
branch
from
933dc5b
to
07aa112
Compare
Closed
nmengin
requested changes
Mar 20, 2018
There was a problem hiding this comment.
Hello @timoreimann .
Many thanks for this very useful PR 👏
Can you update the documentation :
- By precising that
logLevelwill be turned inDEBUGmode only iflogLevelis not specified (in the sentenceAdditionally, the log level will be set to DEBUG.) - By replacing
(--debug switch)by(--logLevel DEBUG switch)inIf applicable, please paste the log output in debug mode (--debug switch)
Thanks!
|
@nmengin good catch -- updated. |
Enabling the debug mode caused the log level to be hard-wired to DEBUG. We change the behavior so that an explicitly defined log level always overrides. One primary motivation is to allow pprof-based benchmarking without excessive DEBUG logging distorting the results. We also remove a piece of code from SetEffectiveConfiguration which was never effective because the log level would already be set previously.
traefiker
force-pushed
the
allow-log-level-override-on-debug-switch
branch
from
17c975b
to
0675ac2
Compare
This was referenced Jan 13, 2022
This was referenced Feb 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Allow overriding the log level in debug mode.
Motivation
Enabling the debug mode caused the log level to be hard-wired to DEBUG. We change the behavior so that an explicitly defined log level always overrides.
One primary motivation is to allow pprof-based benchmarking without excessive DEBUG logging distorting the results.
Additional Notes
We also remove a piece of code from
SetEffectiveConfigurationwhich was never effective because the log level would already be set previously.Fixes #2968.