Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Externalize Træfik rules in a dedicated package #2933

Merged
merged 1 commit into from
Feb 26, 2018
Merged

Externalize Træfik rules in a dedicated package #2933

merged 1 commit into from
Feb 26, 2018

Conversation

nmengin
Copy link
Contributor

@nmengin nmengin commented Feb 26, 2018 •
edited
Loading

What does this PR do?

Træfik rules are managed in the server package.
This PR creates a rules package.

Motivation

Low coupling, High cohesion 😜

@nmengin nmengin added this to the 1.6 milestone Feb 26, 2018
mmatur
mmatur approved these changes Feb 26, 2018
View reviewed changes
Copy link
Member

@mmatur mmatur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ldez
ldez approved these changes Feb 26, 2018
View reviewed changes
Copy link
Contributor

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

juliens
juliens approved these changes Feb 26, 2018
View reviewed changes
Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker merged commit 6f81e34 into traefik:master Feb 26, 2018
@nmengin nmengin deleted the feature/refacto-rules branch February 26, 2018 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ldez ldez ldez approved these changes

@mmatur mmatur mmatur approved these changes

@juliens juliens juliens approved these changes

Assignees
No one assigned
Labels
area/rules kind/enhancement a new or improved feature. size/M
Projects
None yet
Milestone
1.6
Development

Successfully merging this pull request may close these issues.
5 participants
@nmengin @juliens @mmatur @ldez @traefiker