Remove hardcoded frontend prefix in Kubernetes template #2914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldez
added
status/1-needs-design-review
status/2-needs-review
and removed
status/0-needs-triage
status/1-needs-design-review
labels
|
Just a bad copy paste 😄 |
traefiker
force-pushed
the
rate-limiting-frontend
branch
from
47b9f26
to
0b06363
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes a bug related to k8 annotations and template generation.
The hardcoded
frontendprefix forces the generation of new frontends instead of adding the rate limiting or errors into the existing frontend.Motivation
I am trying to run the latest version from master in GKE, and rate limiting was not working.
Additional Notes
Was there any specific reason for adding the
frontendprefix @ldez ?