Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logger and Leaks #2847

Merged
merged 1 commit into from
Feb 12, 2018
Merged

Logger and Leaks #2847

merged 1 commit into from
Feb 12, 2018

Conversation

ldez
Copy link
Contributor

@ldez ldez commented Feb 12, 2018

What does this PR do?

  • Buffer: conditional setter
  • Logs level and Forwarder Logger
  • Fix goroutine leaks

Motivation

Related to vulcand/oxy#118, vulcand/oxy#117, vulcand/oxy#116

@ldez ldez added kind/enhancement a new or improved feature. status/2-needs-review bot/light-review decreases the number of required LGTM from 3 to 1. labels Feb 12, 2018
@ldez ldez added this to the 1.6 milestone Feb 12, 2018
Copy link
Member

@mmatur mmatur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker merged commit 38a4c80 into traefik:master Feb 12, 2018
@traefiker traefiker removed bot/light-review decreases the number of required LGTM from 3 to 1. status/3-needs-merge labels Feb 12, 2018
@ldez ldez deleted the refactor/update-oxy branch February 12, 2018 16:28
@ldez ldez added the area/logs label Sep 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/logs kind/enhancement a new or improved feature. size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants