Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

List entries parsing. #2669

Merged
merged 1 commit into from
Jan 9, 2018
Merged

List entries parsing. #2669

merged 1 commit into from
Jan 9, 2018

Conversation

ldez
Copy link
Contributor

@ldez ldez commented Jan 7, 2018 •
edited
Loading

What does this PR do?

Support list entries in KV.

ex:

foo/0: bar
foo/1: bir
foo/2: bur

Motivation

Fixes #2667

More

Additional Notes

Fully compatible with the previous behavior.

@traefiker traefiker added this to the 1.5 milestone Jan 7, 2018
nmengin
nmengin approved these changes Jan 8, 2018
View reviewed changes
Copy link
Contributor

@nmengin nmengin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mmatur
mmatur approved these changes Jan 9, 2018
View reviewed changes
Copy link
Member

@mmatur mmatur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

juliens
juliens approved these changes Jan 9, 2018
View reviewed changes
Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker merged commit d88554f into traefik:v1.5 Jan 9, 2018
@traefiker traefiker mentioned this pull request Jan 9, 2018
Closed
@ldez ldez deleted the fix/kv-list-entries branch January 9, 2018 14:37
@mmatur mmatur changed the title fix: list entries parsing. List entries parsing. Jan 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nmengin nmengin nmengin approved these changes

@mmatur mmatur mmatur approved these changes

@juliens juliens juliens approved these changes

Assignees
No one assigned
Labels
area/provider/kv kind/bug/fix a bug fix size/S
Projects
None yet
Milestone
1.5
Development

Successfully merging this pull request may close these issues.
5 participants
@ldez @juliens @mmatur @nmengin @traefiker