Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

homogenization of templates: Marathon #2665

Merged
merged 2 commits into from
Jan 10, 2018
Merged

homogenization of templates: Marathon #2665

merged 2 commits into from
Jan 10, 2018

Conversation

ldez
Copy link
Contributor

@ldez ldez commented Jan 6, 2018 •
edited
Loading

What does this PR do?

Simplify template and use typed function.

Motivation

Homogenization of the providers [part3]: try to have a shared template

More

  • Added/updated tests

@ldez ldez added kind/enhancement a new or improved feature. status/2-needs-review labels Jan 6, 2018
@ldez ldez added this to the 1.6 milestone Jan 6, 2018
@ldez ldez requested a review from a team as a code owner January 6, 2018 22:19
@ldez ldez force-pushed the refactor/marathon-template branch 2 times, most recently from 1f4132a to 7c8697f Compare January 7, 2018 16:24
@ldez ldez force-pushed the refactor/marathon-template branch from 7c8697f to d100c1f Compare January 9, 2018 19:29
@ldez ldez removed the bot/no-merge label Jan 9, 2018
juliens
juliens approved these changes Jan 10, 2018
View reviewed changes
Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mmatur
mmatur approved these changes Jan 10, 2018
View reviewed changes
Copy link
Member

@mmatur mmatur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker merged commit 870c0b5 into traefik:master Jan 10, 2018
@ldez ldez deleted the refactor/marathon-template branch January 10, 2018 11:15
@ldez ldez mentioned this pull request Jan 30, 2018
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmatur mmatur mmatur approved these changes

@timoreimann timoreimann timoreimann approved these changes

@juliens juliens juliens approved these changes

Assignees
No one assigned
Labels
area/provider/marathon kind/enhancement a new or improved feature. size/L
Projects
None yet
Milestone
1.6
Development

Successfully merging this pull request may close these issues.
5 participants
@ldez @juliens @timoreimann @mmatur @traefiker