Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow deleting dynamically all TLS certificates from an entryPoint #2603

Merged
merged 2 commits into from
Dec 21, 2017
Merged

Allow deleting dynamically all TLS certificates from an entryPoint #2603

merged 2 commits into from
Dec 21, 2017

Conversation

nmengin
Copy link
Contributor

@nmengin nmengin commented Dec 20, 2017 •
edited
Loading

What does this PR do?

The PR fixes TLS dynamic management by allowing deleting all of certificates from an entryPoint.

Motivation

The entryPoints kept at least one certificate even if user delete all of them from the configuration, the PR fixes this behavior.

More

  • Added/updated tests

@traefiker traefiker added this to the 1.5 milestone Dec 20, 2017
@ldez ldez removed the bot/no-merge label Dec 21, 2017
juliens
juliens approved these changes Dec 21, 2017
View reviewed changes
Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ldez
ldez approved these changes Dec 21, 2017
View reviewed changes
Copy link
Contributor

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mmatur
mmatur approved these changes Dec 21, 2017
View reviewed changes
Copy link
Member

@mmatur mmatur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker merged commit 1e44e33 into traefik:v1.5 Dec 21, 2017
@nmengin nmengin deleted the hotfix/delete-dynamic-certs-with-nil-list branch August 3, 2018 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ldez ldez ldez approved these changes

@mmatur mmatur mmatur approved these changes

@juliens juliens juliens approved these changes

Assignees
No one assigned
Labels
area/tls kind/bug/fix a bug fix size/M
Projects
None yet
Milestone
1.5
Development

Successfully merging this pull request may close these issues.
5 participants
@nmengin @juliens @mmatur @ldez @traefiker