Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve documentation for Cloudflare API key #2558

Merged
merged 2 commits into from
Dec 13, 2017
Merged

Improve documentation for Cloudflare API key #2558

merged 2 commits into from
Dec 13, 2017

Conversation

mmatur
Copy link
Member

@mmatur mmatur commented Dec 11, 2017 •
edited
Loading

What does this PR do?

This PR improve documentation for DNS provider
The Cloudflare Global API Key needs to be used and not the Origin CA Key

More

  • Added/updated documentation

Fixes: #2219

@traefiker traefiker added this to the 1.5 milestone Dec 11, 2017
@mmatur mmatur requested a review from ldez December 11, 2017 13:05
@ldez ldez added status/2-needs-review kind/enhancement a new or improved feature. labels Dec 11, 2017
ldez
ldez approved these changes Dec 11, 2017
View reviewed changes
Copy link
Contributor

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

errm
errm approved these changes Dec 12, 2017
View reviewed changes
Copy link
Contributor

@errm errm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

juliens
juliens approved these changes Dec 13, 2017
View reviewed changes
Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker merged commit 623a7dc into traefik:v1.5 Dec 13, 2017
@traefiker traefiker mentioned this pull request Dec 13, 2017
Closed
@mmatur mmatur deleted the cloudflare-lego-documentation branch March 21, 2018 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ldez ldez ldez approved these changes

@juliens juliens juliens approved these changes

@errm errm errm approved these changes

Assignees
No one assigned
Labels
area/acme area/documentation kind/enhancement a new or improved feature. size/S
Projects
None yet
Milestone
1.5
Development

Successfully merging this pull request may close these issues.
5 participants
@mmatur @errm @juliens @ldez @traefiker