Reduce logs with new Kubernetes security annotations #2506
Conversation
|
I spot one or two things that we may want to improve. Will have a closer look later, please don't merge just yet. |
| if annotation := meta.Annotations[name]; annotation != "" { | ||
| for _, v := range strings.Split(annotation, ",") { | ||
| pair := strings.Split(v, ":") | ||
| func getMapAnnotation(meta *v1beta1.Ingress, labelName string) map[string]string { |
There was a problem hiding this comment.
label has a different connotation in Kubernetes. We should continue to call it name, or go with either annotationName or annotName.
There was a problem hiding this comment.
currently I'm rewriting all labels/annotations system for all providers.
This function is extracted from this work.
I can change for now, but in the future we don't gonna separate labels and annotations.
| } | ||
| } | ||
|
|
||
| if len(mapValue) == 0 { | ||
| log.Errorf("Could not load %q, skipping...", labelName) |
There was a problem hiding this comment.
I think the log messages could be clearer with regards to what the user did wrong, both in terms of wording and how we log.
My suggestion would be to do the following:
- Do a check against the length of
valuesin line 47 and bail out immediately when it's zero along with alog.Errorf("Missing value for annotation %q", values). - Instead of logging an error right away in line 51, collect all illegal pairs first and print them in a comma-joint list inside a single
log.Warnf().
WDYT?
There was a problem hiding this comment.
I agree with the first point.
For the second point, it does not seem necessary because this create a complexity only for logging.
There was a problem hiding this comment.
Re: the second point: My reasoning is that we collect all illegal pairs and show them to the user in a more concise manner.
It'd be nice to have IMHO, though not strictly necessary.
ldez
force-pushed
the
fix/k8s-logs
branch
3 times, most recently
from
7dc4c4a
to
aac1fcd
Compare
traefiker
force-pushed
the
fix/k8s-logs
branch
from
aac1fcd
to
b439288
Compare
What does this PR do?
Reduce logs with new Kubernetes security annotations.
Motivation
Limit the number of unneeded logs.
More
Additional Notes
Fixes #2500