-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make frontend names differents for similar routes #2338
Merged
traefiker
merged 1 commit into
traefik:v1.4
from
nmengin:hotfix/add-idx-to-distinct-frontends
Oct 30, 2017
Merged
Make frontend names differents for similar routes #2338
traefiker
merged 1 commit into
traefik:v1.4
from
nmengin:hotfix/add-idx-to-distinct-frontends
Oct 30, 2017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nmengin
added
area/provider/docker/swarm
kind/bug/fix
a bug fix
status/2-needs-review
and removed
status/0-needs-triage
labels
Oct 27, 2017
juliens
approved these changes
Oct 27, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
mmatur
approved these changes
Oct 27, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👏
ldez
approved these changes
Oct 30, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
traefiker
approved these changes
Oct 30, 2017
traefiker
force-pushed
the
hotfix/add-idx-to-distinct-frontends
branch
from
October 30, 2017 10:32
14c5607
to
a53b762
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Because the frontend names are based on the
route
names, it's not possible to set frontends with similar routes (as described in #1070).This PR adds an index to all frontends names to avoid the problem.
Fixes #1070