Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make frontend names differents for similar routes #2338

Merged

Conversation

nmengin
Copy link
Contributor

@nmengin nmengin commented Oct 27, 2017

Description

Because the frontend names are based on the route names, it's not possible to set frontends with similar routes (as described in #1070).

This PR adds an index to all frontends names to avoid the problem.

Fixes #1070

Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@mmatur mmatur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👏

Copy link
Contributor

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker force-pushed the hotfix/add-idx-to-distinct-frontends branch from 14c5607 to a53b762 Compare October 30, 2017 10:32
@traefiker traefiker merged commit da7b6f0 into traefik:v1.4 Oct 30, 2017
@nmengin nmengin deleted the hotfix/add-idx-to-distinct-frontends branch August 3, 2018 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants