Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix healthcheck port #2131

Merged
merged 2 commits into from
Sep 18, 2017
Merged

Fix healthcheck port #2131

merged 2 commits into from
Sep 18, 2017

Conversation

fredix
Copy link
Contributor

@fredix fredix commented Sep 18, 2017 •
edited by ldez
Loading

Try to fix healthcheck port

according to this bug report : #2099

this fix add some missing code to overriding the healthcheck port.

Fixes #2099

timoreimann
timoreimann reviewed Sep 18, 2017
View reviewed changes
Copy link
Contributor

@timoreimann timoreimann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might it be possible to add a quick test? (The lack of one probably caused the problem in the first place.)

@juliens
Copy link
Member

juliens commented Sep 18, 2017

Thanks
Great PR,
We really want it in the next 1.4-RC, so I will change base branch to 1.4 and add somes integrations tests for you

@fredix
Copy link
Contributor Author

fredix commented Sep 18, 2017

Hi, Juliens,
thanks for doing integration tests, there is some tests at healthcheck/healthcheck_test.go and integration/fixtures/healthcheck/ but I don't know how to improve them.

@fredix fredix requested review from a team as code owners September 18, 2017 10:11
@juliens juliens changed the base branch from master to v1.4 September 18, 2017 10:11
vdemeester
vdemeester approved these changes Sep 18, 2017
View reviewed changes
Copy link
Contributor

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐮

ldez
ldez approved these changes Sep 18, 2017
View reviewed changes
Copy link
Contributor

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

juliens
juliens approved these changes Sep 18, 2017
View reviewed changes
Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ldez ldez added this to the 1.4 milestone Sep 18, 2017
@traefiker traefiker merged commit 49e0e20 into traefik:v1.4 Sep 18, 2017
@traefiker traefiker mentioned this pull request Sep 18, 2017
Closed
@fredix fredix deleted the healthcheck branch September 18, 2017 14:45
@juliens juliens changed the title fix healthcheck port Fix healthcheck port Sep 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timoreimann timoreimann timoreimann left review comments

@ldez ldez ldez approved these changes

@juliens juliens juliens approved these changes

@vdemeester vdemeester vdemeester approved these changes

Assignees
No one assigned
Labels
area/healthcheck kind/bug/fix a bug fix size/S
Projects
None yet
Milestone
1.4
Development

Successfully merging this pull request may close these issues.
6 participants
@fredix @juliens @vdemeester @timoreimann @ldez @traefiker