Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compress: preserve status code #1948

Merged
merged 2 commits into from
Aug 21, 2017
Merged

Conversation

ldez
Copy link
Contributor

@ldez ldez commented Aug 11, 2017

Description

before the fixes: when compress is enable and the content is already compress, the status code is not preserved.

Fixes #1937

@ldez ldez added this to the 1.4 milestone Aug 11, 2017
@ldez ldez changed the title Fix compress status code compress: preserve status code Aug 11, 2017
Copy link
Contributor

@errm errm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ldez ldez force-pushed the fix/gzip-handler branch 3 times, most recently from 0319fc9 to c278029 Compare August 16, 2017 08:24
@ldez ldez added the size/S label Aug 16, 2017
Copy link
Contributor

@nmengin nmengin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker merged commit 5313922 into traefik:master Aug 21, 2017
@ldez ldez deleted the fix/gzip-handler branch August 22, 2017 08:52
@ldez ldez mentioned this pull request Sep 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

when responding with gzip compression traefik converts HTTP 201 to 200 v1.3.5
5 participants