Assign filtered tasks to apps contained in slice. #1881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timoreimann
added
area/provider/marathon
kind/bug/fix
We previously assigned them to a copy of each application, which effectively disabled all filtering. Fixes a bug introduced along commit 779eeba.
timoreimann
force-pushed
the
marathon-assign-filtered-tasks-to-app-slice
branch
from
d308fe9
to
75d1e4d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We previously assigned them to a copy of each application, which effectively disabled all filtering.
Fixes a bug introduced along commit 779eeba.
Ignore the nasty test struct please; in #1871, the fix will look much nicer. :-)
@containous/traefik PTAL.