Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Factorize labels #1843

Merged
merged 30 commits into from
Jul 10, 2017
Merged

Factorize labels #1843

merged 30 commits into from
Jul 10, 2017

Conversation

ldez
Copy link
Contributor

@ldez ldez commented Jul 9, 2017

Description

Centralize all Traefik Labels used across providers.

@ldez ldez added this to the 1.4 milestone Jul 9, 2017
@ldez ldez force-pushed the refactor/factorize-labels branch 3 times, most recently from 5186de9 to f7aac30 Compare July 9, 2017 15:19
nmengin
nmengin approved these changes Jul 10, 2017
View reviewed changes
Copy link
Contributor

@nmengin nmengin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
Improve code maintenance
Avoid typo 😉
LGTM

timoreimann
timoreimann approved these changes Jul 10, 2017
View reviewed changes
Copy link
Contributor

@timoreimann timoreimann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might even be worth putting the labels into a dedicated package so that it reads more fluently:

labels.BackendLoadBalancerMethod

vs.

types.LabelBackendLoadBalancerMethod

Can still be done in the future though.

LGTM, thanks a lot 👏

emilevauge
emilevauge approved these changes Jul 10, 2017
View reviewed changes
Copy link
Member

@emilevauge emilevauge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We all need more commits !
Thanks @ldez
LGTM

@ldez ldez force-pushed the refactor/factorize-labels branch from f7aac30 to e7da1e9 Compare July 10, 2017 14:14
@juliens juliens merged commit d653a34 into traefik:master Jul 10, 2017
@ldez ldez deleted the refactor/factorize-labels branch July 10, 2017 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nmengin nmengin nmengin approved these changes

@emilevauge emilevauge emilevauge approved these changes

@timoreimann timoreimann timoreimann approved these changes

Assignees
No one assigned
Labels
area/provider kind/enhancement a new or improved feature.
Projects
None yet
Milestone
1.4
Development

Successfully merging this pull request may close these issues.
5 participants
@ldez @timoreimann @emilevauge @nmengin @juliens