Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Problem with keepalive when switching protocol failed #1782

Merged
merged 1 commit into from
Jun 26, 2017
Merged

Problem with keepalive when switching protocol failed #1782

merged 1 commit into from
Jun 26, 2017

Conversation

ldez
Copy link
Contributor

@ldez ldez commented Jun 24, 2017

Description

Fixes: #1174

@ldez ldez added this to the 1.3 milestone Jun 24, 2017
@ldez ldez mentioned this pull request Jun 24, 2017
Closed
@ldez ldez force-pushed the fix/switching-protocol-keepalive branch from 5ca0bfa to 1a78cc9 Compare June 24, 2017 12:31
juliens
juliens approved these changes Jun 26, 2017
View reviewed changes
Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

errm
errm approved these changes Jun 26, 2017
View reviewed changes
Copy link
Contributor

@errm errm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM...

although there could be a little more detail in the commit message... but I suppose the full story is in containous/oxy

emilevauge
emilevauge approved these changes Jun 26, 2017
View reviewed changes
Copy link
Member

@emilevauge emilevauge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ldez ldez merged commit f99f3b9 into traefik:v1.3 Jun 26, 2017
@ldez ldez deleted the fix/switching-protocol-keepalive branch June 26, 2017 16:00
@ldez ldez mentioned this pull request Jul 6, 2017
Closed
@ViViDboarder ViViDboarder mentioned this pull request Jul 12, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilevauge emilevauge emilevauge approved these changes

@juliens juliens juliens approved these changes

@errm errm errm approved these changes

Assignees
No one assigned
Labels
area/oxy area/websocket kind/bug/fix a bug fix
Projects
None yet
Milestone
1.3
Development

Successfully merging this pull request may close these issues.
4 participants
@ldez @errm @juliens @emilevauge