Extract providers to their own packages #1444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vdemeester
requested review from
errm,
timoreimann,
SantoDE,
Russell-IO,
emilevauge and
dtomcej
vdemeester
force-pushed
the
extract-providers
branch
6 times, most recently
from
83faf19
to
d71d64c
Compare
timoreimann
suggested changes
Apr 16, 2017
vdemeester
force-pushed
the
extract-providers
branch
8 times, most recently
from
ef87d8f
to
37b443d
Compare
vdemeester
force-pushed
the
extract-providers
branch
from
37b443d
to
1002c6d
Compare
This is just doing that and making it compile :) Signed-off-by: Vincent Demeester <[email protected]>
vdemeester
force-pushed
the
extract-providers
branch
from
1002c6d
to
542c367
Compare
SantoDE
approved these changes
Apr 18, 2017
emilevauge
reviewed
Apr 18, 2017
| Prefix string `description:"Prefix used for KV store"` | ||
| TLS *provider.ClientTLS `description:"Enable TLS support"` | ||
| StoreType store.Backend | ||
| Kvclient store.Store |
There was a problem hiding this comment.
I'm not sure that's a good idea to have these fields exported. They will be added automatically to the flags traefik --help (to be verified).
There was a problem hiding this comment.
@emilevauge I don't see them in --help output. I guess it's only exported field that have the description:"…" thinguy 👼
There was a problem hiding this comment.
OK thanks :) Is there any possibility to not export these fields in the future? Not really fond of this ;)
There was a problem hiding this comment.
@emilevauge yes, it is in my plan somehow 👼
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following #1440, this extracts the other provider to their own packages. Still refactoring to do (some stuff to un-export in k8s for ex, tests refactoring, etc..).
As it's based on #1440, only the last commit sholud be reviewed — and I'll rebase once it's merged 👼
Changes around : +840/-815