Rename health check URL parameter to path. #1285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also improve documentation.
timoreimann
force-pushed
the
rename-healthcheck-url-to-path
branch
from
4eeb679
to
de91b99
Compare
|
CI green, this is ready for review: @containous/traefik |
vdemeester
suggested changes
Mar 14, 2017
|
@vdemeester the feature wasn't available in the previous release yet. We kind of agreed on Slack that changing in the v1.2 branch is still acceptable and doesn't count as a breaking API change. WDYT? |
|
@timoreimann ohhh 👼 right, nevermind.. didn't see that it was the branch, etc… |
|
@timoreimann great job, thanks :) |
emilevauge
approved these changes
Mar 14, 2017
mihaitodor
added a commit
to mihaitodor/traefik
that referenced
this pull request
Apr 26, 2017
This PR traefik#1285 renamed the URL member of types.HealthCheck to "Path", but it didn't update the integration test. I also added the Healthcheck test to the integration suite.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also improve documentation.
@emilevauge @dtomcej as discussed on Slack.