Fix git rpr #1109
Merged
Fix git rpr #1109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vdemeester
reviewed
Feb 3, 2017
|
|
||
| if [ "$#" -ne 1 ]; then | ||
| if [ "$#" -ne 2 ]; then |
There was a problem hiding this comment.
Should we have a default value for the most common case ? (if $2 is not present, use upstream/master for ex 👼 )
vdemeester
suggested changes
Feb 5, 2017
There was a problem hiding this comment.
@emilevauge there is still room for improvement
git fetch -p --all(-pis not required though 👼) to make sure the remotes are all up-to-date- Validate beforehand that the specified remote exists.
emilevauge
force-pushed
the
fix-git-rpr-upstream
branch
from
ac9cecc
to
792570b
Compare
|
@vdemeester I added 1/. On 2/, is it really needed? The script will fail if the specified remote doesn't exist, right ? |
vdemeester
suggested changes
Feb 6, 2017
.github/cpr.sh
Outdated
| @@ -0,0 +1,26 @@ | |||
| #!/bin/sh | |||
| # | |||
| # git config --global alias.rpr '!sh .github/cpr.sh' | |||
There was a problem hiding this comment.
This alias is not right 👼
.github/rmpr.sh
Outdated
| @@ -0,0 +1,27 @@ | |||
| #!/bin/sh | |||
| # | |||
| # git config --global alias.rpr '!sh .github/rmpr.sh' | |||
There was a problem hiding this comment.
This alias is not right 👼 👼
Signed-off-by: Emile Vauge <[email protected]>
Signed-off-by: Emile Vauge <[email protected]>
Signed-off-by: Emile Vauge <[email protected]>
emilevauge
force-pushed
the
fix-git-rpr-upstream
branch
from
792570b
to
c00a9fa
Compare
Added a TRAP calling clean.
Indeed, fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an argument to manage upstream correctly:
git rpr pr remote/branchIt also adds
git rmpr&git cprcommands./cc @vdemeester
Signed-off-by: Emile Vauge [email protected]