Fix marathon provider #1090
Merged
Fix marathon provider #1090
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diegooliveira
force-pushed
the
IP-Per-Task-Fix
branch
from
3f8bbd5
to
8d6b91a
Compare
timoreimann
approved these changes
Jan 31, 2017
|
CI is failing for Docker 1.13, might just be a flake. @diegooliveira, do you want to try to retrigger Travis ( |
|
@timoreimann CI is always failing with Docker 1.13... |
|
@emilevauge gotcha, thanks for the info. |
diegooliveira
force-pushed
the
IP-Per-Task-Fix
branch
from
8d6b91a
to
ca43e5c
Compare
|
Needs another rebase. :-) |
emilevauge
force-pushed
the
IP-Per-Task-Fix
branch
4 times, most recently
from
af9e32c
to
247dcb4
Compare
emilevauge
approved these changes
Feb 3, 2017
The IP-Per-Task PR introduced a bug using the marathon application
port mapping. This port should be used only in the proxy server, the
downstream connection should be always made with the task port.
This commit fix the regression and adds a unit test to prevent new
problems in this setup.
vdemeester
force-pushed
the
IP-Per-Task-Fix
branch
from
247dcb4
to
cbbb5f4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The IP-Per-Task PR introduced a bug using the marathon application
port mapping. This port should be used only in the proxy server, the
downstream connection should always be made with the task port.
This commit fix the regression and adds an unit test to prevent new
problems in this setup.
Fixes #1072