Improving instrumentation. #1042
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brian-brazil
approved these changes
Jan 17, 2017
| @@ -718,7 +722,7 @@ $ curl -s "http://localhost:8080/api" | jq . | |||
| - `/metrics`: You can enable Traefik to export internal metrics to different monitoring systems (Only Prometheus is supported at the moment). | |||
|
|
|||
| ```bash | |||
| $ traefik --web.metrics.prometheus --web.metrics.prometheus.buckets="100,300" | |||
| $ traefik --web.metrics.prometheus --web.metrics.prometheus.buckets="0.1,0.3" | |||
There was a problem hiding this comment.
I'd keep this in line with the defaults.
Histograms only work when all the servers you're aggregating across have the same buckets, so by having this consistent it reduces the scope for mishaps.
SantoDE
requested changes
Jan 17, 2017
| @@ -544,6 +544,10 @@ address = ":8080" | |||
| # [web.statistics] | |||
| # RecentErrors = 10 | |||
| # | |||
| # To enable Traefik to export internal metrics to Prometheus | |||
| # [web.metrics.prometheus] | |||
| # Buckets=[0.1,0.5] | |||
There was a problem hiding this comment.
Please adjust the docs to match with the defaults as well :-)
| # | ||
| # To enable Traefik to export internal metrics to Prometheus | ||
| # [web.metrics.prometheus] | ||
| # Buckets=[0.1,0.5] |
enxebre
force-pushed
the
prometheus-instrumentation
branch
from
a708eb8
to
e56424a
Compare
|
Should be ok now. Thanks! |
|
Cool @enxebre LGTM now 👼 Would you be so kind to just rebase the branch and squash your commits? ping @containous/traefik |
SantoDE
approved these changes
Jan 17, 2017
SantoDE
added
contributor/needs-resolve-conflicts
and removed
contributor/waiting-for-corrections
labels
enxebre
force-pushed
the
prometheus-instrumentation
branch
from
e56424a
to
b027de3
Compare
|
Hey @SantoDE I just rebased it, just in case you didn't know, you can squash and merge the PR from Github straight away |
This was referenced Jan 19, 2017
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some changes for sticking to best practices on instrumentation according to comments here #1022 ping @brian-brazil @SantoDE